Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise ValueError if s3 key does not exist #245

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Raise ValueError if s3 key does not exist #245

merged 1 commit into from
Jan 17, 2019

Conversation

adrpar
Copy link
Contributor

@adrpar adrpar commented Nov 5, 2018 •
edited by menshikh-iv
Loading

As mentioned on ISSUE #174 botocore.client.ClientError is raised instead of ValueError on S3 keys that do not exists.

This PR fixes this inconsistency.

Fix #174

mpenkov
mpenkov requested changes Nov 7, 2018
View reviewed changes
Copy link
Collaborator

@mpenkov mpenkov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Can you please add a test?

Otherwise, it looks good.

@adrpar adrpar force-pushed the ISSUE-174_raise_value_error_if_s3key_not_exists branch from 7b1ec42 to 4d892af Compare November 7, 2018 07:03
@adrpar adrpar force-pushed the ISSUE-174_raise_value_error_if_s3key_not_exists branch from 4d892af to 7a13158 Compare November 7, 2018 07:08
@adrpar
Copy link
Contributor Author

adrpar commented Nov 7, 2018

Thank you for the review. I added the test (thought I could get away with being lazy :) )

mpenkov
mpenkov approved these changes Nov 8, 2018
View reviewed changes
Copy link
Collaborator

@mpenkov mpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@menshikh-iv WDYT?

@menshikh-iv menshikh-iv changed the title ISSUE-174 raise ValueError if s3 key does not exist Raise ValueError if s3 key does not exist Jan 17, 2019
@menshikh-iv
Copy link
Contributor

menshikh-iv commented Jan 17, 2019 •
edited
Loading

Thank you @adrpar, congratz with the first contribution 🥇

@menshikh-iv menshikh-iv merged commit 3ca74c6 into piskvorky:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpenkov mpenkov mpenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't swallow ClientError when bucket doesn't exist
3 participants
@adrpar @menshikh-iv @mpenkov