Ensure _list_bucket uses continuation token for subsequent pages #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The continuation token is being captured when each page of keys is fetched, but it was not used for subsequent requests. This meant that the same page of 1000 keys would repeat forever. This commit adds a fix to ensure the continuation token is used if not None
mpenkov
reviewed
Nov 9, 2018
|
Thank you for this PR. Does the affected test pass now? |
Co-Authored-By: tcsavage <tcsavage@gmail.com>
|
@mpenkov As I mentioned, I was unable to run the tests on my local machine, but I will remove the skip decorator and see if it passes in Travis. |
piskvorky
reviewed
Nov 9, 2018
| @@ -391,7 +391,6 @@ def test_list_bucket(self): | |||
| expected = ['key_%d' % x for x in range(num_keys)] | |||
| self.assertEqual(sorted(keys), sorted(expected)) | |||
|
|
|||
| @unittest.skip('this test takes too long for some unknown reason') | |||
There was a problem hiding this comment.
LOL! Did we catch the error, but commented out its test instead of fixing? :) Who did this?
|
The build failed, but it looks like a problem with |
|
@mpenkov @piskvorky The tests pass, could we merge and release before this gets stale? |
mpenkov
approved these changes
Nov 22, 2018
|
Thank you @tcsavage, congratz with the first contribution 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to
s3_iter_bucketa large set of objects (more than 1000), we found we were given the same set of 1000 over and over again, forever.The issue was that the continuation token to fetch the next page, although it was being captured, was not being given to subsequent invocations of
list_objects_v2. This pull request makes sure that if we have a continuation token, that we use it.Unfortunately, I have been unable to run the test suite but this change should fix the test "test_list_bucket_long" which is currently being skipped because it was taking "too long". Probably because it would run forever.