Add support for .xz / lzma #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
|
@mpenkov All review addressed except #260 (comment) because I feel that refactoring the test suite is a separate task. WDYT? |
Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
|
@mpenkov @piskvorky ping |
mpenkov
approved these changes
Feb 23, 2019
|
This is breaking my builds due to needing |
|
|
|
@vmarkovtsev 9 more months for it to cause me problems 😂 |
|
@tdhopper Sorry for breaking your build. Yes, a PR would be most welcome. You could make it an optional dependency, but my preference would be to move .xz support from the library to the examples in the README. With the new register_compressor functionality, adding support for different compression formats is best done outside the library. |
|
See #281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opened #260