Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes native xz support #282

Merged
merged 3 commits into from
Apr 12, 2019
Merged

Removes native xz support #282

merged 3 commits into from
Apr 12, 2019

Conversation

tdhopper
Copy link
Contributor

Replaces #281 by instead removing native xz-support. Adds more complete examples of a custom decompressor using xz.

@tdhopper
Copy link
Contributor Author

Part of the context here is that release 1.8.1 breaks builds on many Python 2.7 systems that don't have liblzma installed. Also based on @mpenkov's comments that he doesn't want compression bloat.

@piskvorky piskvorky mentioned this pull request Apr 10, 2019
Closed
piskvorky
piskvorky requested changes Apr 10, 2019
View reviewed changes
README.rst Outdated Show resolved Hide resolved
@tdhopper
Removes native xz support
102d5ef 
Updates `register_compressor` example to show xz decompression.
mpenkov
mpenkov requested changes Apr 11, 2019
View reviewed changes
Copy link
Collaborator

@mpenkov mpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's make sure doctest picks up your example in README.rst

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@tdhopper
Copy link
Contributor Author

I've never used the GH review feature so I didn't respond to the requested changes here, but I pushed a new commit that I think fixes your concerns.

@mpenkov mpenkov merged commit ca18f5e into piskvorky:master Apr 12, 2019
@mpenkov
Copy link
Collaborator

mpenkov commented Apr 12, 2019

Looks good. Congrats on your first PR to smart_open @tdhopper 🥇

@tdhopper
Copy link
Contributor Author

@mpenkov Thanks for all the help

@tdhopper
Copy link
Contributor Author

@mpenkov any chance of cutting a release with this? We're having tons of build failures, and I'd rather not pin smart_open in all of our projects.

@caboteria
Copy link
Contributor

Thanks @tdhopper and everyone who jumped on this so quickly!

@mpenkov
Copy link
Collaborator

mpenkov commented Apr 17, 2019

OK, I will cut a release within the next several hours. Thank you for your patience.

@mpenkov
Copy link
Collaborator

mpenkov commented Apr 17, 2019

OK, 1.8.2 is now available from PyPI. Please let me know if you have any further problems, and thanks again for your help in dealing with this.

@tdhopper tdhopper deleted the remove-xz branch April 17, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piskvorky piskvorky piskvorky requested changes

@mpenkov mpenkov mpenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdhopper @mpenkov @caboteria @piskvorky