accept bytearray and memoryview as input to write in s3 submodule

[bmizhen-exos]

Hello, I'd like to add ability to handle memoryview objects.
https://docs.python.org/2/c-api/buffer.html

I encountered this when attempting to wrap a s3 stream in a io.BufferedWriter like this

class MD5BufferedWriter(io.BufferedWriter):
    def __init__(self, output_stream):
        super().__init__(output_stream)
        self.md5 = hashlib.md5()

    def digest(self):
        return self.md5.hexdigest()

    def write(self, b):
        self.md5.update(b)
        return super().write(b)

with MD5BufferedWriter(smart_open.open('s3://bucket/name', 'wb')) as bt:
       bt.write('a'.encode('utf-8'))

[mpenkov]

Thank you for your contribution. Left you a minor comment.

[mpenkov]

Please move this stuff to module scope, and make it an internal constant, e.g. _BINARY_TYPES.

[bmizhen-exos]

Done

[mpenkov]

Looking good. Could you please add a unit test that exercises your new feature?

[bmizhen-exos]

Added a test. Tested to make sure it fails without the fix.

[mpenkov]

Looks good. Left you some minor nitpicks.

[bmizhen-exos]

Hi Michael, can you give me some idea of when this might land in pypi?

[mpenkov]

We just did a bugfix release, I suppose we could do another one in a week or so. Are you in a rush?

[bmizhen-exos]

It would be helpful, otherwise I'll have to live off a branch for a bit.
BTW, do I need to do anything else in order to merge to master?

thanks!

[mpenkov]

No, that's pretty much it, congrats on your first contribution to smart_open! 🥇

[bmizhen-exos]

Thank you!

…

On Thu, Apr 18, 2019, 11:35 PM Michael Penkov ***@***.***> wrote: Merged #293 <#293> into master. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#293 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKOK27AKR2BP5JSGXRKS4V3PRE4YDANCNFSM4HGDAC6Q> .

-- Brokerage services offered through Exos Securities LLC, member of SIPC <http://www.sipc.org/> / FINRA <http://www.finra.org/>. For important disclosures, click here <https://www.exosfinancial.com/disclosures>.

[mpenkov]

Released 1.8.3

[bmizhen-exos]

Thank you!

…

On Fri, Apr 26, 2019, 3:26 AM Michael Penkov ***@***.***> wrote: Released 1.8.3 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#293 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKOK27EDNNJM4QQKFBFZA6TPSKVDRANCNFSM4HGDAC6Q> .

-- Brokerage services offered through Exos Securities LLC, member of SIPC <http://www.sipc.org/> / FINRA <http://www.finra.org/>. For important disclosures, click here <https://www.exosfinancial.com/disclosures>.