Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backward compatibility fixes #294

Merged
merged 3 commits into from
Apr 17, 2019
Merged

backward compatibility fixes #294

merged 3 commits into from
Apr 17, 2019

Conversation

mpenkov
Copy link
Collaborator

@mpenkov mpenkov commented Apr 16, 2019

Fix #290.

Added an older version of our unit tests that target the deprecated smart_open.smart_open function. When run against the most recent implementation, a dozen tests failed because of parameter naming issues. I updated the implementation to handle the parameter renaming and all tests now pass.

@mpenkov mpenkov merged commit b0d97b4 into piskvorky:master Apr 17, 2019
@mpenkov mpenkov deleted the bcompat-fix branch April 17, 2019 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 argument change in 1.8.1 is backwards-incompatible with 1.8.0
1 participant