Don't use s3 bucket_head to check for bucket existence #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is about piskvorky#314 This code caused problems when you have write permission to an s3 bucket path but not read permission to the bucket root. This code was added to prevent implicit bucket creation (to fix issue 154) but it appears that it is no longer needed.
mpenkov
requested changes
May 18, 2019
|
test_buffered_writer_wrapper_works in test_s3.py tests the happy path. test_nonexisting_bucket in test_s3.py tests that the proper exception (ValueError) is thrown when the bucket doesn't exist. Props for great test coverage! |
|
OK, thank you, and congrats on your first contribution to smart_open! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #314 .
This code caused problems when you have write permission to an s3
bucket path but not read permission to the bucket root.
This code was added to prevent implicit bucket creation (to fix issue
#154) but it appears that it is no longer needed.