-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for rt, rt+, wt, wt+, at, at+ methods #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # smart_open/tests/test_http.py
- a - a+ - at - at+
mpenkov
reviewed
Aug 2, 2019
mpenkov
reviewed
Aug 2, 2019
mpenkov
reviewed
Aug 2, 2019
mpenkov
reviewed
Aug 2, 2019
mpenkov
reviewed
Aug 2, 2019
Co-Authored-By: Michael Penkov <m@penkov.dev>
mpenkov
requested changes
Aug 14, 2019
Co-Authored-By: Michael Penkov <m@penkov.dev>
Co-Authored-By: Michael Penkov <m@penkov.dev>
Co-Authored-By: Michael Penkov <m@penkov.dev>
- read text
mpenkov
changed the title
Work in consistency API smart_open with Python API.
Add support for rt, rt+, wt, wt+, at, at+ methods
Aug 27, 2019
move tests that touch the file system to a separate fixture
mpenkov
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.