Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gcs multiple writes #421

Merged
merged 29 commits into from
Mar 16, 2020
Merged

Gcs multiple writes #421

merged 29 commits into from
Mar 16, 2020

Conversation

petedannemann
Copy link
Contributor

fix gcs multiple writes

Motivation

Checklist

Before you create the PR, please make sure you have:

  • Picked a concise, informative and complete title
  • Clearly explained the motivation behind the PR
  • Linked to any existing issues that your PR will be solving
  • Included tests for any new functionality
  • Checked that all unit tests pass

@petedannemann
Copy link
Contributor Author

@mpenkov do you think you will have the chance to review this soon? Fixing this bug would be great if we plan to release the GCS feature (#423)

mpenkov
mpenkov requested changes Mar 8, 2020
View reviewed changes
Copy link
Collaborator

@mpenkov mpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I've finally found some to review it. Please have a look.

smart_open/gcs.py Outdated Show resolved Hide resolved
smart_open/gcs.py Outdated Show resolved Hide resolved
smart_open/gcs.py Outdated Show resolved Hide resolved
smart_open/gcs.py Outdated Show resolved Hide resolved
smart_open/tests/test_gcs.py Outdated Show resolved Hide resolved
@mpenkov mpenkov added this to the 1.10.0 milestone Mar 8, 2020
@petedannemann petedannemann requested a review from mpenkov March 9, 2020 14:08
mpenkov
mpenkov requested changes Mar 10, 2020
View reviewed changes
Copy link
Collaborator

@mpenkov mpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better. Left you some minor comments, please have a look.

smart_open/gcs.py Outdated Show resolved Hide resolved
smart_open/gcs.py Outdated Show resolved Hide resolved
@petedannemann petedannemann requested a review from mpenkov March 10, 2020 14:41
mpenkov
mpenkov requested changes Mar 15, 2020
View reviewed changes
smart_open/gcs.py Outdated Show resolved Hide resolved
smart_open/gcs.py Show resolved Hide resolved
@petedannemann petedannemann requested a review from mpenkov March 15, 2020 15:21
@mpenkov
Copy link
Collaborator

mpenkov commented Mar 16, 2020

Thank you for your patience. Merging.

@mpenkov mpenkov merged commit aab385c into piskvorky:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpenkov mpenkov mpenkov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

GCS Writing multiple times does not work
2 participants
@petedannemann @mpenkov