Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix WebHDFS read method #433

Merged
merged 3 commits into from
Mar 16, 2020
Merged

fix WebHDFS read method #433

merged 3 commits into from
Mar 16, 2020

Conversation

mpenkov
Copy link
Collaborator

@mpenkov mpenkov commented Mar 15, 2020

Fix #388

The existing WebHDFS implementation was poorly tested. I fixed the bug, and added some unit tests.

Checklist

Before you create the PR, please make sure you have:

  • Picked a concise, informative and complete title
  • Clearly explained the motivation behind the PR
  • Linked to any existing issues that your PR will be solving
  • Included tests for any new functionality
  • Checked that all unit tests pass

@mpenkov mpenkov requested a review from piskvorky March 15, 2020 09:07
piskvorky
piskvorky approved these changes Mar 15, 2020
View reviewed changes
smart_open/webhdfs.py Show resolved Hide resolved
@mpenkov mpenkov merged commit 9ff0215 into piskvorky:master Mar 16, 2020
@mpenkov mpenkov deleted the webhdfs-fixup branch March 16, 2020 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piskvorky piskvorky piskvorky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebHDFS readline() for single line not working
2 participants
@mpenkov @piskvorky