Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make S3 uploads more robust #434

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Make S3 uploads more robust #434

merged 3 commits into from
Mar 16, 2020

Conversation

mpenkov
Copy link
Collaborator

@mpenkov mpenkov commented Mar 15, 2020

Fix #244

Checklist

Before you create the PR, please make sure you have:

  • Picked a concise, informative and complete title
  • Clearly explained the motivation behind the PR
  • Linked to any existing issues that your PR will be solving
  • Included tests for any new functionality
  • Checked that all unit tests pass

@mpenkov mpenkov changed the title Retry if failed Make S3 uploads more robust Mar 15, 2020
@mpenkov mpenkov requested a review from piskvorky March 15, 2020 11:08
@mpenkov mpenkov merged commit e706de1 into piskvorky:master Mar 16, 2020
@mpenkov mpenkov deleted the retry-if-failed branch March 16, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piskvorky piskvorky piskvorky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 upload failing silently if the connection lost during upload
2 participants
@mpenkov @piskvorky