Fix error when calling str() or repr() on GCS SeekableBufferedInputBase #442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
__repr__
and__str__
ongcs.SeekableBufferedInputBase
by storing the bucket as_bucket
instead ofbucket
.This is now consistent with
gcs.BufferedOutputBase
ands3. _SeekableRawReader
(which stores its S3 client as_object
)Motivation
We were seeing logging errors originating from smart_open: