Drop mock dependency; standardize on unittest.mock #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we require Python 3.6+, unittest.mock is available, and it was already used in some of the tests. Migrate any tests still using the PyPI backport package “mock” to unittest.mock, and drop the dependency.
piskvorky
approved these changes
May 19, 2021
mpenkov
approved these changes
May 25, 2021
There was a problem hiding this comment.
Thank you @musicinmybrain ! Congrats on your first PR to the smart_open repo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Drop mock dependency; standardize on unittest.mock
Motivation
Since the package requires Python 3.6+,
unittest.mockis available, and it was already used in some of the tests. Migrate any tests still using the PyPI backport packagemocktounittest.mock, and drop the dependency.This came up while looking at a candidate package for Fedora Linux, where the PyPI
mockpackage is deprecated.Tests
No tests to add; existing tests pass.
Checklist
Before you create the PR, please make sure you have:
Workflow
Please avoid rebasing and force-pushing to the branch of the PR once a review is in progress.
Rebasing can make your commits look a bit cleaner, but it also makes life more difficult from the reviewer, because they are no longer able to distinguish between code that has already been reviewed, and unreviewed code.