Don't leak compressed stream (#630) #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ampanasiuk
force-pushed
the
bug630_gzipfile_leak
branch
from
46ea033 to
07cff02
Compare
* Don't leak compressed stream Transparent compression works by adapting the binary stream with the GzipFile or BZ2File class. These, however, by design don't close the adapted stream. Add a matching CompressionFormatTest.test_closes_compressed_stream test.
ampanasiuk
force-pushed
the
bug630_gzipfile_leak
branch
from
07cff02 to
8c3d33b
Compare
|
Thank you for taking care of this! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transparent compression works by adapting the binary stream with the
GzipFile or BZ2File class. These, however, by design don't close the
adapted stream. Add a matching
CompressionFormatTest.test_closes_compressed_stream test.