drop deprecated ignore_ext parameter #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
reviewed
Oct 11, 2021
There was a problem hiding this comment.
Thanks, looks good. But what's the migration path? What should users with ignore_ext in their code do now?
I checked https://github.com/RaRe-Technologies/smart_open/blob/develop/MIGRATING_FROM_OLDER_VERSIONS.rst and it says only The ignore_extension keyword parameter is now called ignore_ext. It behaves identically otherwise..
|
OK, added migration docs. Please have a look. |
|
@piskvorky I'm going to merge this now, and release 6.0.0 within the next several days. Please have a look and let me know if anything looks fishy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from #607
We currently have two mutually exclusive parameters, ignore_ext (deprecated) and compression. We introduced the new one and marked the old one as deprecated about 6 months ago. I think sufficient time has passed for us to remove this parameter.
We still have a function for compatibility with ancient code (smart_open.smart_open). That's still there and remains the same.
This is a backwards-incompatible change, so we should probably put it in the same release as #660