Add flake8 config globally #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpenkov
approved these changes
Oct 16, 2022
|
Merged, thank you! |
davidparks21
pushed a commit
to davidparks21/smart_open
that referenced
this pull request
Oct 18, 2022
* Add flake config globally * Remove un-used import
davidparks21
pushed a commit
to davidparks21/smart_open
that referenced
this pull request
Oct 18, 2022
* Add flake config globally * Remove un-used import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making a PR on the project I got caught out by the
flake8linter and the build failed. Equally, I wasnt sure which formatter was in use by the project.By configuring flake8 globally this it makes it possible to not get caught out by the CI linting step and ensure the code is formatted correctly on first commit. I guess this is somewhat similar to the changes in #718 but we worried about different aspects of contributing. Both cover different aspects that could be helpful.
I have made the list of errors that are faliling slightly more explicit to just the ones that are failing but equally happy to relax that again if prefered.