Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: Remove pathlib2 #733

Merged
merged 1 commit into from
Oct 16, 2022
Merged

setup.py: Remove pathlib2 #733

merged 1 commit into from
Oct 16, 2022

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Oct 15, 2022

Title

Remove test dependency pathlib2

Motivation

No longer needed.

Checklist

Before you create the PR, please make sure you have:

  • Picked a concise, informative and complete title
  • Clearly explained the motivation behind the PR
  • Linked to any existing issues that your PR will be solving
  • Included tests for any new functionality
  • Checked that all unit tests pass

Workflow

Please avoid rebasing and force-pushing to the branch of the PR once a review is in progress.
Rebasing can make your commits look a bit cleaner, but it also makes life more difficult from the reviewer, because they are no longer able to distinguish between code that has already been reviewed, and unreviewed code.

@mpenkov mpenkov merged commit a356703 into piskvorky:develop Oct 16, 2022
@mpenkov
Copy link
Collaborator

mpenkov commented Oct 16, 2022

Thank you!

davidparks21 pushed a commit to davidparks21/smart_open that referenced this pull request Oct 18, 2022
davidparks21 pushed a commit to davidparks21/smart_open that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants