Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS Support #9

Open
panckreous opened this issue May 29, 2019 · 3 comments
Open

SCSS Support #9

panckreous opened this issue May 29, 2019 · 3 comments
Labels
👍 Enhancement New feature or request 🙏 Help wanted Extra attention is needed

Comments

@panckreous
Copy link

If it's possible to eventually extend support to Sass and SCSS well, that would just make this even more amazing.

@Tchekda
Copy link

Tchekda commented May 29, 2019

Scss is already support as written in the Readme at the third point of supported files, i think sass is not that difficult to adapt so I think it will be released soon

@Raathigesh
Copy link
Owner

@Tchekda is right. SCSS is already supported. My immediate focus is to enhance the current functionality so I won't be focusing on SASS anytime soon. That being said, I'm more than happy to help if you want to contribute SASS support. We use Postcss as the parser and if they support SASS, then we should be able to integrate it fairly easily.

@paustint paustint added 👍 Enhancement New feature or request 🙏 Help wanted Extra attention is needed labels Jun 1, 2019
@paustint
Copy link
Collaborator

paustint commented Jun 1, 2019

From what I can see, this should be supported. We would need to add in the postcssSass syntax, then update css-file.ts to choose sass based on the languageId provided based on the filetype.

This would be really easy to implement from a parsing perspective, but I don't know if there are other considerations about updating SASS as compared to CSS and SCSS.

https://github.com/AleshaOleg/postcss-sass

var postcssSass = require("postcss-sass");

postcss(plugins).process(sass, { syntax: postcssSass }).then(function (result) {
    result.content // Sass with transformations
});

@Raathigesh Raathigesh changed the title Sass/SCSS Support SCSS Support Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Enhancement New feature or request 🙏 Help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants