Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If image_tag input is separated with ", " no push occurs #20

Closed
thedmeyer opened this issue Sep 2, 2021 · 2 comments
Closed

If image_tag input is separated with ", " no push occurs #20

thedmeyer opened this issue Sep 2, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@thedmeyer
Copy link

If the image_tag variable has an input like below, a push never occurs and no error is given.

image_tag: latest, another-tag

Is this correct behavior, to assume a true CSV input?
such that:

image_tag: latest,another-tag
function split_csv() {
    IFS=','
    csv_data=$1
    local -n global_list_array=$2
    for i in $csv_data; do
        global_list_array+=($i)
    done
    unset IFS
}
@RafikFarhad
Copy link
Owner

Hi @thedmeyer, thanks for using this action.
If the input is not a CSV or contains unsupported character (in this case whitespace) then this action should throw error.
I'll fix this behaviour soon. Thanks for reporting.

@RafikFarhad RafikFarhad added the bug Something isn't working label Sep 3, 2021
@RafikFarhad RafikFarhad self-assigned this Sep 3, 2021
@RafikFarhad
Copy link
Owner

RafikFarhad commented Jun 18, 2022

Hi @thedmeyer, this issue has been handled from v4.1. Now the action will try to sanitize the image name by removing whitespaces and empty tag names. Also, latest will be used when the tag_names is un-parsable.
Thanks for reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants