Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with recipe name collisions #347

Open
vfonic opened this issue Oct 25, 2015 · 1 comment
Open

Issues with recipe name collisions #347

vfonic opened this issue Oct 25, 2015 · 1 comment

Comments

@vfonic
Copy link
Contributor

vfonic commented Oct 25, 2015

I wanted to slightly modify extras recipe so I created a local recipe and changed the matter so it belongs to new category:

__END__

name: extras
description: "Various extras."
author: vfonic

requires: [gems]
run_after: [gems, init]
category: dvelp

Now on the prompt, I see this:

Available Recipes:
admin admin
apps learn_rails, rails_bootstrap, rails_devise, rails_devise_pundit, rails_devise_roles, rails_foundation, rails_mailinglist_activejob, rails_omniauth, rails_signup_download, rails_stripe_checkout, rails_stripe_coupons, rails_stripe_membership_saas
collections core
configuration email, gems, git, railsapps, readme, setup
development deployment, email_dev
dvelp extras
example example
frontend frontend
initialize init
mvc devise, omniauth, pages, roles
other analytics, extras, locale
testing tests
Which recipe would you like to add? (blank to finish)

I'd like to be able to add dvelp/extras, without other/extras. At the moment it seems like every recipe must have unique name. There's no namespacing (per category or organization).

The reason for using the same name is that I want to know which of my recipes is a fork of original recipe from this repo.

I think the fix could be done somewhere in these lines:
https://github.com/RailsApps/rails_apps_composer/blob/master/lib/rails_wizard/command.rb#L97

@DanielKehoe
Copy link
Member

Sounds worthwhile. Can you fork and prepare a pull request for me to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants