Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build OrderSubmitted as a EventSummary #221

Open
andrzejkrzywda opened this issue Dec 20, 2022 · 2 comments
Open

Build OrderSubmitted as a EventSummary #221

andrzejkrzywda opened this issue Dec 20, 2022 · 2 comments

Comments

@andrzejkrzywda
Copy link
Contributor

The goal is to then have consumers use this event.
Then we can get rid of Ordering::OrderLines because they are only used for the need of this event.

Also, it will help to eliminate some "processes".

@pjurewicz
Copy link
Collaborator

Then we can get rid of Ordering::OrderLines because they are only used for the need of this event.

It turns out that there is one invariant that takes advantage of order_lines:
raise CannotRemoveZeroQuantityItem if @basket.quantity(product_id).zero?

@andrzejkrzywda
Copy link
Contributor Author

I don't think this is an important feature. We can move it to somewhere else (pricing?) or get rid of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants