Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please include nqp-configure in the release tarballs #699

Open
pstumpf opened this issue Feb 28, 2021 · 7 comments
Open

Please include nqp-configure in the release tarballs #699

pstumpf opened this issue Feb 28, 2021 · 7 comments

Comments

@pstumpf
Copy link

pstumpf commented Feb 28, 2021

As the title says. As a downstream packager, this would make my work a lot easier.

@Altai-man Altai-man added the BLOCKER Preventing the next release of NQP, or just needing attention before the release label Mar 1, 2021
@patrickbkr
Copy link
Member

@pstumpf Is this really about the submodule in the NQP source release files? (Which I suspect few people actually know about.) Or is this actually about the rakudo source release files? (The ones linked to on the http://rakudo.org/downloads website.)

@Altai-man If I understand this ticket correctly it's basically a matter of adapting the release procedure. Isn't this ticket then better solved by you?

@pstumpf
Copy link
Author

pstumpf commented May 3, 2021

@patrickbkr Yes, this is about the source releases generated from this (Raku/nqp) github repository.

@vrurg
Copy link
Contributor

vrurg commented May 4, 2021

This issue is confusing me now. I just have checked out rakudo sources available via download on rakudo.org and found nqp-configure included. Then downloaded https://github.com/Raku/nqp/releases/download/2021.04/nqp-2021.04.tar.gz from this repo and it contains the submodule too. 2021.03 is no different.

It currently looks like it's harder to find a source tarball without nqp-configure than with it included. @pstumpf could you, please, elaborate as to where do you download from?

@Altai-man Altai-man removed the BLOCKER Preventing the next release of NQP, or just needing attention before the release label May 4, 2021
@Altai-man
Copy link
Member

@vrurg I think the ticket is about "nqp-2021.04.tar.gz" we generate in this repo.
It boils down to make release in nqp repo not skipping the nqp-configure directory, I'll look into it.

@patrickbkr
Copy link
Member

@pstumpf Did you possibly download the archive labeled "Source Code (ext)"? Those are auto-generated by GitHub for every package and are best ignored. That's a plain bundle of the files of the respective tag.

@patrickbkr
Copy link
Member

@Altai-man IIU vrurg correctly, those archives already contain nqp-configure. So the archives should already be fine. Question is: Can we do something about people downloading the auto-generated "Source Code" archives? Is it possible to add some descriptive text to the GitHub package? If yes we could add a short warning: "The nqp-*.tar.gz file contains the packaged source code of the release. Please ignore the Source Code (ext) files, those are automatically generated by GitHub ant contain the unprepared files of the repository."

@Altai-man
Copy link
Member

Hmm, actually you are right, nqp-configure is present in the release tarball for this repo.
@pstumpf can you please clarify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants