You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unfortunately AtomicI64 sacrifices portability; see #204. It's possible that different interfaces will behave differently when dealing with numbers of entities above i32::MAX. I'd be happy to accept PRs to mitigate this or otherwise improve consistency, but I'm not convinced that supporting more than 2 billion entities is important.
In
Entities::alloc
we are trying to convert the total number of entities tou32
, so the maximum number of entities isu32::MAX
. InEntities::alloc_many
we are directly comparing number tou32::MAX
. But in Entities::reserve_entities,Entities::alloc_at
,Entities::reserve
and many other places in codeiszie
is used, so on a 32-bit system these functions expect the maximum number to bei32::MAX
, which is half ofu32::MAX
.Entities::free_cursor
is alsoAtomicIsize
.Is my observation correct? Is this intentional behaviour? Should iszie be replaced by i64?
The text was updated successfully, but these errors were encountered: