Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore operation-oriented Bundle refactor #249

Open
Ralith opened this issue Jan 30, 2022 · 1 comment
Open

Explore operation-oriented Bundle refactor #249

Ralith opened this issue Jan 30, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@Ralith
Copy link
Owner

Ralith commented Jan 30, 2022

The current Bundle traits are data-oriented, exposing properties of the bundle, and fairly complex as a result of that, and somewhat unstable besides. This ugliness is part of why they're currently considered an impl detail. If we instead orient the trait interfaces around performing desired operations directly, the result might be significantly cleaner, even after exposing necessary interfaces on World/etc for implementers to call into.
@Ralith Ralith added the enhancement New feature or request label Jan 30, 2022
@Ralith Ralith mentioned this issue Jan 30, 2022
Merged
@Ralith
Copy link
Owner Author

Ralith commented Mar 13, 2022

This might also help us get rid of the ugly double indirect function call in <&BuiltEntityClone as DynamicBundle>::put.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ralith