-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crashes when used with multiple storyboards. #93
Comments
maybe your forget step 3 (For each UITabBarItem, set the class to RAMAnimatedTabBarItem.) |
Unfortunately not. Everything is in place and as mentioned I know how to make it work on a single storyboard. You should also be able to reproduce the bug (if it is one) by setting it up so it works on a single storyboard, then refactor to multiple storyboards. For me it breaks every time. You can make it work on multiple storyboards by refactor to multiple storyboards from the second view controller related to each tab item, but that's not what you want when organizing a larger app. |
I set up a clean repo demonstrating how the crash occurs (link below). Roll back to the single storyboard version to see that all works and then when refactoring to multiple storyboards, it breaks. https://github.com/HumidBrains/BrokenRAMAnimatedTabBar.git |
the problem is tabBar.items doesn't inherited from RAMAnimatedTabBarItem then use multiple storyboards screen |
I'm able to replicate this as well. |
@HumidBrains I just made my own class class AnimatedTabBarController: UITabBarController {
} You can of course incorporate your own animation...but this saved me a lot of time I would've spent debugging |
I was seeing this same issue. A workaround is to create a container view controller and embed your other view controller that can be in a separate Storyboard. You'll need to declare the custom tab bar item as well as the animation object in the container view controller. I've created a repo and a detailed README for how to this here. Thanks to @jeffaburt for the help looking into this! |
I have got same issue. When I test it on real device from XCode it works fine. Also same issue with #139 I didn't check @jrmsklar solution yet. Try to solve it using another methods for now. |
All works great for me if all view controllers are on the same storyboard. However, when using multiple storyboards, I can't find a setup that works. However I do I get this error...
fatal error: items must inherit RAMAnimatedTabBarItem
Maybe someone else has experienced this problem and has a solution to this? Thanks.
The text was updated successfully, but these errors were encountered: