Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed extension, and still no option to render table with data-table? #118

Closed
RollsChris opened this issue Mar 29, 2022 · 10 comments
Closed
Labels
duplicate This issue or pull request already exists

Comments

@RollsChris
Copy link

Installed extension, and still no option to render table with data-table?
i have tried the rest book examples and still no option
image

Do i need to do anything else to get this working?

@RandomFractals
Copy link
Owner

@RedEyedDog this was patched in #114 to support new custom text/x-json mime type used by REST book for json outputs and will be released soon.

@RollsChris
Copy link
Author

Ok thanks.. any idea when it will be fixed?

Can I just ask you a quick couple questions :)

I'm writing a custom notebook and id like to use your table to display the data.. do I need to install this extension along side mine or does the user need to have it installed?

I presume if I just set the Output mime type to the one you support.. it will show up as a renderer? that would be grrreat

Sorry still a nooobster with vscode extensions

Thanks

@RandomFractals
Copy link
Owner

RandomFractals commented Mar 30, 2022

that issue is already fixed and will be released this week. I am wrapping up a few other things like new flat data grid addition described in #115.

You do need to install this extension in order to use them as alternative renderers in your custom notebooks. As long as you have cells that output content in the supported mime type formats, all the data table renderers in this extension should work with your custom notebooks or kernels.

Here is the list of supported data outputs from our package.json renderer declarations:

  "displayName": "Data Table",
        "mimeTypes": [
          "application/json",
          "application/geo+json",
          "application/vnd.code.notebook.stdout",
          "application/xml",
          "text/csv",
          "text/plain",
          "text/x-json",
          "text/xml"
        ]

@RollsChris
Copy link
Author

Thanks, easier than i thought then ;)

@RandomFractals
Copy link
Owner

RandomFractals commented Mar 30, 2022

yeah, some things are broken in the published version now, like TS notebooks & I have not tested recent .Net Interactive notebook updates, but I plan to keep this extension current and patch those issues as they arise. Some of the custom vscode notebook kernels still change frequently and are not very stable. I would recommend you use it with Py notebooks for now.

As long as you output CSV text or JSON objects from your cell, you'd be able to use current data table and summary renderers, and the new Flat Data Grid renderer added in #115 is kind of like a combo of both.

Give me a day or two to wrap up my update release. Also, feel free to share what notebooks you'd use it for.

@RollsChris
Copy link
Author

I'm currently helping on the SQL Notebook vscode extension.. we are outputting in markup mime type with a table...its not nice and i think this would be perfect.. it should be easy to get the response into json format so lets hope its smoooth sailing :)

@RandomFractals
Copy link
Owner

btw, XPath notebooks have our data table renderers integrated for their outputs. You can see how they do it there too:

https://github.com/DeltaXML/vscode-xpath-notebook#auto-completion

@RandomFractals RandomFractals added the duplicate This issue or pull request already exists label Mar 30, 2022
@RandomFractals
Copy link
Owner

RandomFractals commented Mar 30, 2022

@RedEyedDog also, you can declare this ext. as a dependency for your SQL notebook vscode extension, if you'd like to have it installed automatically with your extension for your users to use.

Just add this to your ext. package.json:

	"extensionDependencies": [
		"RandomFractalsInc.vscode-data-table"
	],
``

@RollsChris
Copy link
Author

RollsChris commented Mar 30, 2022 via email

@RollsChris
Copy link
Author

Hey i have just initiated a PR into SQL Notebooks which makes data-table a dependency, not much else to do really except change our output mime types to application/json :)

Thanks for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants