Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async: Python 3.7 support doesn't directly work #1401

Closed
numbermaniac opened this issue Jul 9, 2018 · 6 comments
Closed

async: Python 3.7 support doesn't directly work #1401

numbermaniac opened this issue Jul 9, 2018 · 6 comments
Labels
duplicate This is a duplicate of another issue or PR.

Comments

@numbermaniac
Copy link
Contributor

numbermaniac commented Jul 9, 2018

First of all it seems like this commit was never actually pushed to pypi as it still breaks until I change it manually, even though I'm on the latest 0.16.12 version.

Even if you do fix that manually, you still can't run discord.py in Python 3.7 because the websockets<4.0,>=3.1 aiohttp<1.1.0,>=1.0.0 requirements don't have the equivalent 3.7 fixes installed - they only came in later versions outside these ranges.

@numbermaniac numbermaniac changed the title Python 3.7 support doesn't directly work async: Python 3.7 support doesn't directly work Jul 9, 2018
@Harmon758
Copy link
Contributor

Harmon758 commented Jul 9, 2018

You can pip install directly from GitHub for that commit.
You can also upgrade those dependencies after installing discord.py, or install with the --no-dependencies flag if you already have them upgraded.
However, you are correct in that the async branch doesn't currently support Python 3.7.
I'd recommend that you downgrade to 3.6 or switch to the rewrite branch if you want to use 3.7.
Also note, the latest websockets release doesn't support 3.7 yet, so you'd have to upgrade websockets from GitHub, even on the rewrite branch.

@Harmon758
Copy link
Contributor

Harmon758 commented Jul 17, 2018

Websockets 6.0 has been released, with Python 3.7 support, so the rewrite branch should work by upgrading websockets from PyPI now.

@Harmon758
Copy link
Contributor

Harmon758 commented Aug 11, 2018

I believe the async branch now also works on Python 3.7 when installed from GitHub and with up to date aiohttp and websockets versions. However, support with these versions isn't guaranteed, so I'd still recommend either downgrading to Python 3.6 or switching to the rewrite branch to use 3.7.

Also, the rewrite branch updated the websockets requirement with 34ece4d, so upgrading websockets separately isn't necessary anymore.

@paulofreitas
Copy link

paulofreitas commented Nov 30, 2018

For those interested, this is the command you need to instal the rewrite branch via pip3:

pip3 install git+https://github.com/Rapptz/discord.py@rewrite

👍

@Chaotic
Copy link

Chaotic commented Feb 28, 2019

This is causing issues with Home Assistant now home-assistant/core#21374

Any chance the fix could be pushed to pippy?

@MusicOnline
Copy link
Contributor

If there was the chance, the fix would've been pushed to PyPI long ago.
That last commit (in the async branch) was around Nov 13, 2017, about 470 days ago.

The next push to PyPI will happen in March or so.
That push will be v1.0.0, the rewrite branch, which includes many breaking changes.

@Harmon758 Harmon758 mentioned this issue Mar 30, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This is a duplicate of another issue or PR.
Projects
None yet
Development

No branches or pull requests

6 participants