Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: RareDevs/Rare
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.10.11.335
Choose a base ref
...
head repository: RareDevs/Rare
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.10.11.341
Choose a head ref
  • 6 commits
  • 2 files changed
  • 1 contributor

Commits on Jul 23, 2024

  1. SteamShortcuts: do not quote executable and start dir 

    fixes: #425
    @loathingKernel
    loathingKernel committed Jul 23, 2024
    Loading
    Loading status checks…
    Copy the full SHA
    c671642 View commit details

  2. Merge pull request #426 from loathingKernel/develop 

    SteamShortcuts: do not quote executable and start dir
    @loathingKernel
    loathingKernel authored Jul 23, 2024
    Loading
    Loading status checks…
    Copy the full SHA
    8f456e0 View commit details

  3. SteamShortcuts: quote the executable, steam does it by default when a… 

    …dding a shortcut
    @loathingKernel
    loathingKernel committed Jul 23, 2024
    Copy the full SHA
    87c72d4 View commit details

  4. SteamShortcuts: don't quote exe on Windows but do on other platforms

    @loathingKernel
    loathingKernel committed Jul 23, 2024
    Copy the full SHA
    21402a6 View commit details

  5. RareLauncher: Don't spawn the console window for detached processes a… 

    …utomatically
    @loathingKernel
    loathingKernel committed Jul 23, 2024
    Loading
    Loading status checks…
    Copy the full SHA
    715ce73 View commit details

  6. Merge pull request #427 from loathingKernel/develop 

    Do not quote executable path for steam shortcuts on Windows
    @loathingKernel
    loathingKernel authored Jul 23, 2024
    Loading
    Loading status checks…
    Copy the full SHA
    219d2e1 View commit details
Showing with 8 additions and 6 deletions.
  1. +4 −3 rare/commands/launcher/__init__.py
  2. +4 −3 rare/models/steam.py
7 changes: 4 additions & 3 deletions rare/commands/launcher/__init__.py
View file
Original file line number Diff line number Diff line change
@@ -153,9 +153,10 @@ def __init__(self, args: InitArgs):
language = self.settings.value(*options.language)
self.load_translator(language)

if QSettings(self).value(*options.log_games) or (
game.app_name in DETACHED_APP_NAMES and platform.system() == "Windows"
):
# if QSettings(self).value(*options.log_games) or (
# game.app_name in DETACHED_APP_NAMES and platform.system() == "Windows"
# ):
if QSettings(self).value(*options.log_games):
self.console = ConsoleDialog(game.app_title)
self.console.show()

7 changes: 4 additions & 3 deletions rare/models/steam.py
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import platform
import binascii
import shlex
from dataclasses import dataclass, field
@@ -108,9 +109,9 @@ def create(
shortcut = cls.from_dict({})
shortcut.appid = cls.calculate_appid(app_name)
shortcut.AppName = app_title
shortcut.Exe = shlex.quote(executable)
shortcut.StartDir = shlex.quote(start_dir)
shortcut.icon = shlex.quote(icon)
shortcut.Exe = executable if platform.system() == "Windows" else shlex.quote(executable)
shortcut.StartDir = start_dir
shortcut.icon = icon
shortcut.LaunchOptions = shlex.join(launch_options)
return shortcut