Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔒 Seize strategy can create underflow #115

Open
transmissions11 opened this issue Mar 4, 2022 · 0 comments
Open

🔒 Seize strategy can create underflow #115

transmissions11 opened this issue Mar 4, 2022 · 0 comments

Comments

@transmissions11
Copy link
Contributor

seize strategy is rly unsafe imo, consider removing. regardless, this line can cause underflow in totalHoldings.

should change to if (lockedProfit() > totalStrategyHoldings - strategyBalance)

vaults/src/Vault.sol

Line 856 in 2edd5eb

if (strategyBalance > totalHoldings()) maxLockedProfit = 0;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@transmissions11