Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy: Fix [has-type] #8241

Closed
2 tasks done
wochinge opened this issue Mar 18, 2021 · 2 comments · Fixed by #8988
Closed
2 tasks done

mypy: Fix [has-type] #8241

wochinge opened this issue Mar 18, 2021 · 2 comments · Fixed by #8988
Assignees
@ancalita
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@wochinge
Copy link
Contributor

wochinge commented Mar 18, 2021 •
edited by ancalita
Loading

Maxime recently enabled mypy support for the first couple of issues. In our current setup we ignore certain typing issues as there are currently too many to tackle them all at once.

We should instead tackle them step by step. Related issue. Parent issue.

Current number of issues with this type: 9

Definition of Done:

  • enable mypy checks for [has-type]
  • all existing [has-type] issues are fixed
@wochinge wochinge added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Mar 18, 2021
@TyDunn TyDunn added the effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. label Jun 4, 2021
@ancalita
Copy link
Member

@wochinge to double-check, here I just need to remove has-type from this assignment and run make types to check for issues ( + fix these issues)?

@wochinge
Copy link
Contributor Author

yep 👍🏻

@ancalita ancalita mentioned this issue Jul 1, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ancalita ancalita

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable mypy checks for has-type RasaHQ/rasa
3 participants
@wochinge @TyDunn @ancalita