Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ovpn config filenames with brackets doesn't work #1661

Closed
8 tasks done
jimmyjones2 opened this issue Sep 18, 2024 · 1 comment · Fixed by #1662
Closed
8 tasks done

[Bug]: ovpn config filenames with brackets doesn't work #1661

jimmyjones2 opened this issue Sep 18, 2024 · 1 comment · Fixed by #1662

Comments

@jimmyjones2
Copy link

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Issue reporting checklist

Operating System

Raspberry Pi OS (64-bit) Lite Bookworm

Quick install or Manual setup?

Quick install

Onboard wireless chipset or external adapter?

Onboard wireless chipset

Hardware

Raspberry Pi Zero W

RaspAP version

3.1.3 (Latest)

Other software or services running with RaspAP?

No other software

Contact details (optional)

No response

Bug description

I've tried to upload openvpn config file profile-openvpn(6).ovpn but this caused errors in the UI and the config wasn't added.

It looks as if filenames are not escaped/quoted in the shell commands within the PHP causing the failure, e.g. https://github.com/RaspAP/raspap-webgui/blob/master/includes/openvpn.php#L131 (and another few instances within the same file)

Steps to reproduce

Upload openvpn profile with filename profile-openvpn(6).ovpn

Screenshots

No response

Additional context

No response

Relevant log output

No response

@billz
Copy link
Member

billz commented Sep 20, 2024

@jimmyjones2 thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants