Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements and bug fix for WiFi Configuration page #261

Closed
PRO2XY opened this issue Nov 11, 2018 · 4 comments
Closed

Enhancements and bug fix for WiFi Configuration page #261

PRO2XY opened this issue Nov 11, 2018 · 4 comments

Comments

@PRO2XY
Copy link

PRO2XY commented Nov 11, 2018

Enhancements and bug fix for WiFi Configuration page

I have made some changes to configure_client.php and /etc/sudoers to:

  • Add RSSI / Signal strength field for scanned networks
  • Add connect button to connect to a particular SSID
  • Make password masked and add 'show' button
  • Repair WiFi scanning (add -i option on wpa_cli calls)
  • Rename $scanned_networks to $networks as expected in the rest of the document

Files are uploaded in a gist: https://gist.github.com/PRO2XY/2ceaeb2d80e32356ea65b6ad60d87a02

I had not git pulled the files initially so I can't create a PR, but maybe someone else can.

Expected behaviour

You should be able to see a page like this

screenshot

@billz
Copy link
Member

billz commented Nov 13, 2018

@PRO2XY many thanks. Masking the passphrase has been on my todo list. The RSSI/signal strength and UI enhancements are nice additions as well. I'll test these changes, incorporate them into an update and credit you as the contributor.

@billz
Copy link
Member

billz commented Nov 13, 2018

Refactored configure client with these enhancements and @njkeng's mobile friendly UI treatment. Looking good and (finally) more manageable on small mobile devices. The passphrase visibility toggle is cool and enhances security by discouraging shoulder surfing.

raspap-client

@1ubuntuuser
Copy link

Looks great! Looking forward to the release.

@billz billz closed this as completed in d2fc5e4 Nov 15, 2018
@PRO2XY
Copy link
Author

PRO2XY commented Nov 20, 2018

Great to see the updates! Mobile view looks much better now! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants