Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the background-color attribute #820

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Add support for the background-color attribute #820

merged 6 commits into from
Sep 30, 2024

Conversation

LaurenzV
Copy link
Contributor

No description provided.

@RazrFalcon
Copy link
Collaborator

Is this task finished?

@LaurenzV
Copy link
Contributor Author

I think so? 😄

@RazrFalcon
Copy link
Collaborator

Good. Just wanted to clarify.

@RazrFalcon RazrFalcon merged commit 0e99286 into linebender:master Sep 30, 2024
3 checks passed
@RazrFalcon
Copy link
Collaborator

Thanks!

@LaurenzV LaurenzV deleted the background-color branch September 30, 2024 07:02
@yisibl
Copy link
Contributor

yisibl commented Sep 30, 2024

This is a bit strange, there is also a shorthand background property in CSS. Should we support it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazrFalcon RazrFalcon RazrFalcon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LaurenzV @RazrFalcon @yisibl