-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fread's na.strings argument should handle values like "-999" #1314
Comments
Benchmarks on 0.1, 0.01, 0.3 and na_rich scenarios after raising the if-statement. # File thisFR stable (6f99651)
# 0.1 51.421 48.068
# 0.01 51.776 54.264
# 0.001 52.255 50.820
# 0.3 48.150 47.930
# na_rich 17.570 17.354 |
@arunsrinivasan, nice catch! Surprised by this timings! |
@dselivanov thanks. I wasn't clear with what the timings were. It's without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With @dselivanov's excellent PR, providing
na.strings
value doesn't result in columns being coerced to character anymore.There's still one point left to address though, as mentioned under that PR -- cases like these:
read.table()
handles them correctly.The text was updated successfully, but these errors were encountered: