Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend auto indexing to multiple columns #1453

Closed
arunsrinivasan opened this issue Nov 30, 2015 · 5 comments
Closed

Extend auto indexing to multiple columns #1453

arunsrinivasan opened this issue Nov 30, 2015 · 5 comments

Comments

@arunsrinivasan
Copy link
Member

(and eventually to any type of logical operation). This would be very efficient as the number of condition increases (as binary search reduces the search space with every condition).

@franknarf1
Copy link
Contributor

franknarf1 commented Feb 16, 2016

This came up on SO: http://stackoverflow.com/q/35438190/1191259 Might want to post an answer there when this is implemented.

Another (though it might get deleted): http://stackoverflow.com/q/43635968/

@jangorecki
Copy link
Member

without binary search it could be done now, if using under the hood with Reduce over x[i = ..., which = TRUE] many queries with indexes and combined.

@arunsrinivasan arunsrinivasan modified the milestones: v2.0.0, v1.9.8 Mar 9, 2016
@arunsrinivasan
Copy link
Member Author

Moving this to next release (should be straightforward after non-equijoins are done (hopefully)).

@MarkusBonsch
Copy link
Contributor

My PR #2494 addresses the optimized subsetting on multiple columns with & connection like DT[a==1 & b == 2]. Additionally, support for the %chin% operator was introduced. However, <, <=, >, >= are not yet supported. Neither are queries that are connected by | like DT[a==2 | b==3].

@mattdowle mattdowle removed this from the Candidate milestone May 10, 2018
@jangorecki
Copy link
Member

I am not sure if we should keep this issue open. Auto index has been extended to work on multiple columns by @MarkusBonsch PR. The OR operator is not yet there, but as per initial comment

as binary search reduces the search space with every condition

It was not really asking for | but for &.

Unless there is an idea to address other stuff, I would close the issue, it is quite broadly defined and biggest part of it has been already addressed. If we want to keep it open, it is best to list precisely what is to be done, so it will be clear what is left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants