-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
non-equi-join: foo is i.bar instead of x.foo if on = "foo>=bar" #2602
Comments
A fix would certainly involve a breaking change. A similar thing occurs with rolling joins. The confusion arises because with 'equi' joins only one column is needed, so the duplicate column is dropped. There it is a little less unexpected because the columns have the same name. Consider a[b, on = "foo==bar"]
merge(a, b, by.x = "foo", by.y = "bar") |
@HughParsonage that is very likely true. Maybe less breaking: return only one column as before, but the real |
I like this idea, raising it to an error if "strict scope" (#633) is on, so that the user has to write
Also related, I think: #1615 (which illustrates that the problem is present in equi-joins too) |
Definitely a duplicate, e.g. #2307. |
I find the here-described behaviour very confusing. It is closely related and probably the root-cause of the following issues:
#2595, #2569
The text was updated successfully, but these errors were encountered: