Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: make unique = TRUE default for CJ #3297

Open
jaapwalhout opened this issue Jan 19, 2019 · 1 comment
Open

FR: make unique = TRUE default for CJ #3297

jaapwalhout opened this issue Jan 19, 2019 · 1 comment
Labels
breaking-change issues whose solution would require breaking existing behavior

Comments

@jaapwalhout
Copy link

The unique-parameter of CJ was initially set to FALSE when introduced. The relevant item in the newsfile when 1.9.6 was released said:

CJ gains logical unique argument with default FALSE. If TRUE, unique values of vectors are automatically computed and used. This is convenient, for example, DT[CJ(a, b, c, unique=TRUE)] instead of doing DT[CJ(unique(a), unique(b), unique(c))]. Ultimately, unique = TRUE will be default. Closes #1148.

As CJ is probably mostly used used with unique = TRUE (see also the original issue), maybe the time has come to set this parameter to unique = TRUE ?

@jangorecki
Copy link
Member

Anyone depending on duplicates can be badly affected. We could make 1.12.2-1.13.0 a transition period where extra check for uniqueness could be added. In case of detecting duplicates and missing(unique) a warning could be raise about changing that default from 1.13.0.

@MichaelChirico MichaelChirico added the breaking-change issues whose solution would require breaking existing behavior label Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change issues whose solution would require breaking existing behavior
Projects
None yet
Development

No branches or pull requests

3 participants