Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang-tidy to CI #2781

Open
mattdowle opened this issue Apr 22, 2018 · 2 comments · May be fixed by #6580
Open

Add clang-tidy to CI #2781

mattdowle opened this issue Apr 22, 2018 · 2 comments · May be fixed by #6580
Labels
ci help-wanted

Comments

@mattdowle
Copy link
Member

As suggested by @michaelquinn32 here: #2738 (comment)
@mattdowle mattdowle added the ci label Apr 22, 2018
@jangorecki jangorecki self-assigned this Apr 29, 2018
@jangorecki jangorecki added this to the v1.11.2 milestone Apr 29, 2018
@mattdowle mattdowle removed this from the v1.11.4 milestone May 1, 2018
@jangorecki jangorecki removed their assignment May 8, 2018
@jangorecki
Copy link
Member

https://clang.llvm.org/extra/clang-tidy/

This could be added on top of our current clang test job:

data.table/.gitlab-ci.yml

Lines 179 to 183 in 685d51d

## R-devel on Linux clang
# R compiled with clang, flags removed: -flto=auto -fopenmp
# tests for compilation warnings
# tests for new notes
test-lin-dev-clang-cran:

@MichaelChirico
Copy link
Member

#4859

Is another PR fixing an issue identified by clang-tidy, as evidence that we could use CI to prevent backsliding on this type of thing.

@ben-schwen ben-schwen linked a pull request Oct 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci help-wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add clang-tidy to GLCI Rdatatable/data.table
3 participants
@mattdowle @jangorecki @MichaelChirico