Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assigning using := on a join is throwing an "..allow.cartesian" error in 1.9.3 #837

Closed
rsaporta opened this issue Sep 29, 2014 · 3 comments
Labels

Comments

@rsaporta
Copy link
Contributor

The code below works fine in 1.9.2 and broke in 1.9.3

:= is throwing the "rerun with allow.cartesian=TRUE" error

DT1 <- data.table(key="id", id=c(1:3, 1:3))
DT2 <- data.table(key="id", id=seq(10), name=LETTERS[1:10])


DT1[DT2, name := i.name]
@rsaporta rsaporta changed the title := / allow.cartesian broken in 1.9.3 Assigning using := on a join is throwing an "..allow.cartesian" error in 1.9.3 Sep 29, 2014
@rsaporta rsaporta added the bug label Sep 29, 2014
@arunsrinivasan
Copy link
Member

I think this is a duplicate of #800.

@rsaporta
Copy link
Contributor Author

Possibly. The discussion on #800 appeared to be more of FR / understanding, but the root issue seems the same.

It appears that notjoin in [.data.table is failing to resolve to TRUE in update-type calls

@arunsrinivasan
Copy link
Member

@rsaporta right. It's not a FR. Ed marked it as such, and I just forgot to change. In the text I'd written:

"However, on your first point, even though i has duplicate values (and therefore the error message is right), the fact that the end result will never be greater than nrow(x) warrants for that error message to be a bug."

Will change it to a bug, and close this (this post will anyways be referred to in the other post).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants