Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forderv should be able to deal with more than one data.table efficiently. #925

Open
arunsrinivasan opened this issue Oct 31, 2014 · 0 comments

Comments

@arunsrinivasan
Copy link
Member

Currently forder takes a single atomic vector, list or data.table as input. But it'd be much useful for so many other internal functions if it'd also accept a list of data.tables.

If that were possible, for example, unique.data.table's function definition could be changed to:

unique.data.table <- function(x, ..., incomparables =,  ) {
    x = list(x, ...) # in R v3.1 or using data.table internal functions to not copy the list
    # rest of the code
}

This allows us to optionally obtaining the unique of a list of data.tables without having to rbind them first.

Even more, this is extremely useful for all the setops functions, issue #547. Specifically, this line - where crux of the computations happen could be made much more (memory + speed) efficient!

Also could be useful in implementing #873.

@jangorecki jangorecki changed the title forder should be able to deal with more than one data.table efficiently. forderv should be able to deal with more than one data.table efficiently. Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant