-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vignettes #944
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'm curious about what makes a cold by faster than say |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Being new to R and data.table (since March), I would say that there needs to be a basic outcome-oriented introduction as opposed to the current function-oriented one. In other words, it is one thing to read what each parameter in data.table does, but they often make little sense without having a use-case in mind. While there are examples of output, many people need to go the other direction. That is, they know what output they need, but they don't know what function/parameter/setting is most appropriate to use. It would be helpful to have a simple recipe approach to get them started. How to I create subsets of my data? There are probably a ton of other items all on SO that could be edited into a simple compilation of questions and answers. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Great work on these vignettes!
for (j in valCols)
set(dt_,
i = which(is.na(dt_[[j]])),
j = j,
value= as.numeric(originTable[[j]])) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thank you for the updated vignettes with the release of v1.9.8. "However we could improve this functionality further by shallow copying instead of deep copying. In fact, we would very much like to provide this functionality for v1.9.8. We will touch up on this again in the data.table design vignette." But the design vignette is missing and the link points to an old issue. The reference manual does not provide more information on Will this vignette become available soon? |
+1 for internals vignette. I (and I guess a few others) am quite interested in contributing a bit on the C side of things, but am a bit intimidated by the (as it stands) 35k lines of C code... quite the learning curve to 'go it alone' -- an intro to internals could do wonders! |
This comment has been minimized.
This comment has been minimized.
Wanted to chime in and ask if contributions to the vignette are accepted from non-code contributors (like me). I am particularly interested in contributing to the joins vignette as I had quite a bit of trouble with it initially and was guided to solutions from Arun's answers on Stackoverflow, and I'd like some guidance on how to do so, if allowed. |
@arunsrinivasan I see that you have a point In addition, I am preparing a first draft on some of the topics suggested by jan. Perhaps parts of it may be relevant for a join vignette as well? I'm happy to share if anyone may find it useful. |
@zeomal such a contribution would be highly valuable and much appreciated! |
@MichaelChirico, thank you. @Henrik-P, will your brief on normal joins be comprehensive - i.e. will your focus be more on timeseries? If not, I can start work on it - I haven't used rolling joins yet, so no knowledge there. :) |
@zeomal Hopefully I will be able to upload the first draft soon, so you can have a look at it. In my draft, I provide a simple example of a "normal" join on a single variable, time, where there are non-matching rows. I use My idea was that this simple join could provide a context and a feeling for the problem, which I then treat more thoroughly in the following sections on rolling and non-equi joins et al. Thanks a lot for your willingness to contribute! . |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@zeomal If you wish to check how brief my treatment on normal (equi) joins is, I just want to let you know that I posted a PR on a timeseries vignette. |
HTML vignette series:
Planned for
v1.9.8
i.col
usage as filed in Docs: explain and document the i.col notation for joins #1038. d) Also cover about performance/advantages fromon
performing slower than doublesetkey
#1232.[ ] Covercovered in programming on data.table #4304get()
andmget()
. E.g., http://stackoverflow.com/q/33785747/559784on=
argument for joins #1623).Future releases
fread
+rbindlist
), ordering, ranking and set operationsdata.table()
anddata.frame()
somewhere - relevant issues: Creation of data.table using a list #968, data.table(x) != as.data.table(x) #877. Perhaps slightly more in detail in the FAQ.data.table
usage:fread+fwrite
vignette, include also Convenience features of fread wiki, also fread (and fwrite) vignette #2855Finished:
i
, select / do inj
and aggregations usingby
.i
andby
in the same way as before)by=.EACHI
until the vignette is done.Minor:
integer64
, and promoting it for large integers.Notes (to update current vignettes based on feedbacks): Please let me know if I missed anything..
Introduction to data.table:
order
ini
.j
while selecting/computing..SDcols
and cols inwith=FALSE
being able to select columns ascolA:colB
.Reference semantics:
set*
functions here.. (setnames
,setcolorder
etc..)set
.1b) the := operator
is just defining ways to use it - the example there doesn't work as it just shows two different ways of using it -- Following this comment.Keys and fast binary search based subsets:
FAQ (most appropriate here, I think).
readRDS()
. Update this SO post.alloc.col()
, and when to use it (when you need to create multiple columns), and why. Update this SO post.The text was updated successfully, but these errors were encountered: