Skip to content
This repository has been archived by the owner on Jul 4, 2019. It is now read-only.

Delete Polls When User Is Deleted #46

Open
Ralkage opened this issue Aug 16, 2018 · 5 comments
Open

Delete Polls When User Is Deleted #46

Ralkage opened this issue Aug 16, 2018 · 5 comments
Labels
good first issue Good for newcomers

Comments

@Ralkage
Copy link
Member

Ralkage commented Aug 16, 2018

Not sure if this is a bug or should just be put as a feature but when users are deleted VIA user profile UI option, their discussions and posts get deleted but their polls don't.

There should be added functionality that when this action occurs, the user's polls in the database get deleted as well.

@Ralkage Ralkage added good first issue Good for newcomers needs discussion Issue needs to be discussed before a decision is made to work on such feature labels Aug 16, 2018
@dsevillamartin
Copy link
Member

We either want to keep the poll or CASCADE on delete. Flarum for beta 8 has a DB changes PR, not sure if CASCADE or keeping discussions & posts like reddit does was decided.

@Ralkage Ralkage pinned this issue Jan 7, 2019
@KyrneDev
Copy link
Contributor

Let's just modify to use cascade, flarum forces innodb now so we should have 0 issues.

@Ralkage
Copy link
Member Author

Ralkage commented Mar 2, 2019

@datitisev or @cdk2020 lets get this implemented by the end of this month if possible 🤗

@JoshStrobl
Copy link

I'm actually facing an issue as well with not being able to delete the user when they've engaged in a poll. See flarum/framework#1802 (comment)

@dsevillamartin
Copy link
Member

We probably want to support [deleted] users, so apart from a migration (set null on delete), some code will also have to be rewritten to allow for non existent users's votes.

@dsevillamartin dsevillamartin removed the needs discussion Issue needs to be discussed before a decision is made to work on such feature label Jun 27, 2019
@dsevillamartin dsevillamartin unpinned this issue Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants