Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revanced cli writes all "INFO" information into stderr instead of stdout #62

Closed
supericqicq3 opened this issue Jun 25, 2022 · 1 comment

Comments

@supericqicq3
Copy link

For example, running

java -jar cli.jar -a *.apk -o revanced.apk -b patches.jar -m integrations.apk -l

results in output

INFO: general-ads: Patch to remove general ads in bytecode. 
INFO: video-ads: Patch to remove ads in the YouTube video player. 
INFO: custom-branding: Change the branding of YouTube. 
INFO: premium-heading: Show the premium branding on the the YouTube home screen. 
INFO: minimized-playback: Enable minimized and background playback. 
INFO: disable-fullscreen-panels: Disable comments panel in fullscreen view. 
INFO: old-quality-layout: Enable the original quality flyout menu. 
INFO: disable-create-button: Disable the create button. 
INFO: amoled: Enables pure black theme. 
INFO: disable-shorts-button: Hide the shorts button. 
INFO: hide-cast-button: Patch to hide the cast button. 
INFO: microg-support: Patch to allow YouTube ReVanced to run without root and under a different package name. 
INFO: background-play: Enable playing music in the background. 
INFO: exclusive-audio-playback: Add the option to play music without video. 
INFO: codecs-unlock: Enables more audio codecs. Usually results in better audio quality but may depend on song and device. 
INFO: upgrade-button-remover: Remove the upgrade tab from the pivot bar in YouTube music. 
INFO: tasteBuilder-remover: Removes the "Tell us which artists you like" card from the Home screen. The same functionality can be triggered from the settings anyway.

which is written to STDERR

@EdgE790
Copy link
Contributor

EdgE790 commented Jun 25, 2022

This is default implementation of logger. It logs everything at info level and higher to StdErr.
Moreover currently I don't see clean solution for it: we can change this to StdOut, but then Warning and Error will be duplicated, because java.util.logging don't allow to create upper bound (e.g. log to StdOut only INFO but not higger - e.g.: warn and err).
Completely disabling StdErr is not the best solution, because errors could be missed.

I'm trying to do this, properly (without duplicating output to both StdOut and StdErr) but I doubt it will be merged, because it will be ugly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants