Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show suggested version in patch logs #1550

Closed
4 tasks done
KobeW50 opened this issue Dec 4, 2023 · 0 comments · Fixed by #1557
Closed
4 tasks done

feat: Show suggested version in patch logs #1550

KobeW50 opened this issue Dec 4, 2023 · 0 comments · Fixed by #1557
Assignees
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented Dec 4, 2023

Feature description

It will add the suggested version of the app to exported patch logs, like this:

- Patch Info
App: com.google.android.apps.youtube.music v6.28.52
Suggested app version: Any
Patches version: v2.202.0
Patches added: Background play, Vanced MicroG support
...

Or like this: (as suggested in #1552)

- Patch Info
App: com.google.android.apps.youtube.music v6.28.52 (Suggested: Any)
Patches version: v2.202.0
Patches added: Background play, Vanced MicroG support
...

Motivation

  1. Without this, the person diagnosing the user's issue may need to manually check what the suggested version is, especially if the app that is being patched is not commonly patched or new patches recently released that changed the suggested version to a version that the diagnoser doesn't know of.

  2. This can help highlight if the user is accidentally on an older patches version (due to Auto updates being disabled). (Although I understand that the patches version is already displayed in the log)

Additional context

No response

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The issue is solely related to the ReVanced Manager
@KobeW50 KobeW50 added the Feature request Requesting a new feature that's not implemented yet label Dec 4, 2023
@validcube validcube self-assigned this Dec 6, 2023
@validcube validcube linked a pull request Dec 6, 2023 that will close this issue
@KobeW50 KobeW50 closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants