Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(dev branch): User is able to prematurely exit out of the patching screen #1645

Closed
validcube opened this issue Jan 21, 2024 · 2 comments · Fixed by #1663
Closed

bug(dev branch): User is able to prematurely exit out of the patching screen #1645

validcube opened this issue Jan 21, 2024 · 2 comments · Fixed by #1663
Assignees
@BenjaminHalko
Labels
Bug report Something isn't working

Comments

@validcube
Copy link
Member

validcube commented Jan 21, 2024 •
edited
Loading

The change is likely the cause of the PopScope Migration

RVMF version: acb1e24
@validcube
Copy link
Member Author

Screen_Recording_20240121_204433_ReVanced.Manager.Debug.mp4

@validcube validcube mentioned this issue Jan 21, 2024
Merged
@validcube validcube changed the title bug(dev branch): User is to be able to prematurely exit out of the patching screen bug(dev branch): User is able to prematurely exit out of the patching screen Jan 22, 2024
@BenjaminHalko BenjaminHalko self-assigned this Jan 27, 2024
@BenjaminHalko BenjaminHalko mentioned this issue Jan 29, 2024
Merged
@BenjaminHalko BenjaminHalko linked a pull request Jan 29, 2024 that will close this issue
fix(PopScope): User able to exit patch screen when the installer is still running #1663
Merged
@validcube validcube added the Bug report Something isn't working label Jan 31, 2024
@validcube validcube linked a pull request Feb 3, 2024 that will close this issue
chore: Merge dev to main #1611
Merged
@Ushie
Copy link
Member

Ushie commented Feb 3, 2024

Given this issue existed only in the dev branch, it makes sense to be closed as completed

@Ushie Ushie closed this as completed Feb 3, 2024
@Ushie Ushie removed a link to a pull request Feb 25, 2024
chore: Merge dev to main #1611
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenjaminHalko BenjaminHalko

Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@BenjaminHalko @Ushie @validcube