Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add automatically the integrations version when saving APK #2273

Closed
3 tasks done
Kuddus73 opened this issue Oct 26, 2024 · 1 comment
Closed
3 tasks done

feat: Add automatically the integrations version when saving APK #2273

Kuddus73 opened this issue Oct 26, 2024 · 1 comment
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@Kuddus73
Copy link

Feature description

I think this PR can be quite useful to implement the feature as it is basically the same feature, but this time it appends the integrations version: feat: append patch version to the APK name while sharing/exporting

When saving a patched APK, add also the integrations version next to the patches version (like youtube-revanced_v19.16.39-patches_v4.17.0-integrations_v1.16.0.apk).
Image

Motivation

The version of the integrations might not be important with ReVanced source because with the release of a new patches version also a new integrations version gets released.

However, other resources, like piko, many times they only release a new version of integrations without releasing a new version of patches, so automatically adding also the integrations version when saving the APK would help to not overwrite by mistake a previously saved APK with the same version, which is very useful if the current/latest release has a bug that causes a crash on startup, and so making it impossible to use that app until a fix is released.

I know we can just manually write the integrations version when saving, but this way would save time and also make the process more automatic and quick.

Acknowledgements

  • I have checked all open and closed feature requests and this is not a duplicate.
  • I have chosen an appropriate title.
  • The feature request is only related to ReVanced Manager.
@Kuddus73 Kuddus73 added the Feature request Requesting a new feature that's not implemented yet label Oct 26, 2024
@oSumAtrIX
Copy link
Member

Integrations version can be determined by the release time of the patches. Besides integrations are merged into patches in Patcher v20

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

2 participants