Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: YouTube ReVanced crashes upon playing video #346

Closed
4 tasks done
ghost opened this issue Oct 3, 2022 · 17 comments
Closed
4 tasks done

bug: YouTube ReVanced crashes upon playing video #346

ghost opened this issue Oct 3, 2022 · 17 comments
Labels
Bug report Something isn't working

Comments

@ghost
Copy link

ghost commented Oct 3, 2022

Type

Error at runtime

Bug description

Once YouTube is patched by Revanced Manager (root mode), upon playing any video the app crashes.

Steps to reproduce

  • Install YouTube app v17.36.37
  • Install ReVanced Manager v0.0.28
  • In ReVanced Manager, after granting all required permissions, go to Patcher and select the installed YouTube app
  • Select all chosen patches (in this example, to keep it simple, I selected only General Ads 0.0.1 and Video Ads 0.0.1)
  • Start patching, then once successfully patched choose Install as Root
  • Open patched YouTube app and play a video

Android version

Android Version: 13
Phone: Rooted Pixel 6 XL
Kernel version: 5.10.107-android13-4-00008-g466e95df8c7c-ab8760753
#1 Thu Jun 23 15:42:45 UTC 2022
Build number: TP1A.220905.004

Manager version

0.0.28

Target package name

YouTube

Target package version.

17.36.37 - arm64 - v8a - nodpi

Installation type

Root

Patches selected.

General Ads 0.0.1
Video Ads 0.0.1

Device logs (exported using Manager settings).

--------- beginning of system
10-03 14:17:14.947 29456 29456 W PackageParser: Unknown element under <manifest>: queries at /data/user/0/app.revanced.manager.flutter/cache/file_picker/com.google.android.youtube_17.36.37-1531571648_minAPI26(arm64-v8a,armeabi-v7a,x86,x86_64)(nodpi)_apkmirror.com.apk Binary XML file line #41
10-03 14:17:49.455 29456 29456 W PackageParser: Unknown element under <manifest>: queries at /data/user/0/app.revanced.manager.flutter/cache/file_picker/com.google.android.youtube_17.36.37-1531571648_minAPI26(arm64-v8a,armeabi-v7a,x86,x86_64)(nodpi)_apkmirror.com.apk Binary XML file line #41
--------- beginning of main
10-03 14:38:36.900 29456 29456 E SurfaceSyncer: Failed to find sync for id=0
10-03 14:38:36.900 29456 29456 E SurfaceSyncer: Failed to find sync for id=1
10-03 14:38:36.900 29456 29456 E SurfaceSyncer: Failed to find sync for id=2
10-03 14:38:36.900 29456 29456 E SurfaceSyncer: Failed to find sync for id=3
10-03 14:38:36.900 29456 29456 E SurfaceSyncer: Failed to find sync for id=4
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=5
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=6
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=7
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=8
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=9
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=10
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=11
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=12
10-03 14:38:36.901 29456 29456 E SurfaceSyncer: Failed to find sync for id=13
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=0
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=1
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=2
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=3
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=4
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=5
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=6
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=7
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=8
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=9
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=10
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=11
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=12
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=13
10-03 14:38:50.309 29456 29456 E SurfaceSyncer: Failed to find sync for id=14
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=0
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=1
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=2
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=3
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=4
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=5
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=6
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=7
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=8
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=9
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=10
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=11
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=12
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=13
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=14
10-03 14:40:04.594 29456 29456 E SurfaceSyncer: Failed to find sync for id=15
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=0
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=1
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=2
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=3
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=4
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=5
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=6
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=7
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=8
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=9
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=10
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=11
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=12
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=13
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=14
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=15
10-03 14:40:30.685 29456 29456 E SurfaceSyncer: Failed to find sync for id=16

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

No response

Screenshots or videos

No response

Solution

No response

Additional context

Tried clearing YouTube app's cache and data, did not resolve.
Tried using different patches, did not resolve.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • The issue is related solely to the ReVanced Manager
@ghost ghost added the Bug report Something isn't working label Oct 3, 2022
@ghost ghost changed the title bug: YouTube revanced crashes upon playing video bug: YouTube ReVanced crashes upon playing video Oct 3, 2022
@jclohmann
Copy link

I can confirm this bug. I'm using the same patcher and youtube version.

@LorisTecnology
Copy link

got the same exact issue
solved by simply reboot my device

@ghost
Copy link
Author

ghost commented Oct 3, 2022

Rebooting did not help in my case.

@Aunali321
Copy link
Contributor

uninstall updates for youtube, Install full apk from apkmirror(17.36.37,120mb+), and select yt from application selector and patch it. make sure to exclude microg patch.

@ghost
Copy link
Author

ghost commented Oct 5, 2022

That's exactly how I installed it. But still got the issue.
P.S. For the time being I'm using the magisk module which doesn't cause any crashes.

@ViktorVoloshko
Copy link

This must be in patches repo not here. Here is only app bugs.

@thijsi123
Copy link

thijsi123 commented Jan 2, 2023

This started happening today for me (also crashes trying to preload videos without pressing on them), just updated the manager re-patched my YouTube with the same patches I always use.
Recommend YouTube version, this now happens with older manager version too, I also tried removing the root/data/adb/services.d/YouTube file no luck.
YouTube music has no problems.

@oSumAtrIX
Copy link
Member

Please grep for "AndroidRuntime" while using logcat and catch the exception

@thijsi123
Copy link

I have no idea what that means, but I'll try my best!

@thijsi123
Copy link

FATAL EXCEPTION: main
Process: com.google.android.youtube, PID: 12606
aslz: The exception could not be delivered to the consumer because it has already canceled/disposed the flow or the exception has nowhere to go to begin with. Further reading: https://github.com/ReactiveX/RxJava/wiki/What's-different-in-2.0#error-handling | java.lang.NoClassDefFoundError: Failed resolution of: Lapp/revanced/integrations/patches/downloads/DownloadsPatch;
at aqvq.w(PG:8)
at aslj.run(PG:2)
at android.os.Handler.handleCallback(Unknown Source:2)
at android.os.Handler.dispatchMessage(Unknown Source:4)
at android.os.Looper.loopOnce(Unknown Source:176)
at android.os.Looper.loop(Unknown Source:77)
at android.app.ActivityThread.main(Unknown Source:155)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(Unknown Source:11)
at com.android.internal.os.ZygoteInit.main(Unknown Source:306)
Caused by: java.lang.NoClassDefFoundError: Failed resolution of: Lapp/revanced/integrations/patches/downloads/DownloadsPatch;
at com.google.android.apps.youtube.app.common.player.PlaybackLifecycleMonitor.l(PG:4)
at fmq.a(PG:46)
at atkn.tt(PG:2)
at asuu.tt(PG:1)
at asur.d(PG:10)
at asur.tt(PG:2)
at astw.g(PG:1)
at astu.run(PG:1)
at aewa.run(PG:3)
at aslj.run(PG:1)
... 8 more
Caused by: java.lang.ClassNotFoundException: app.revanced.integrations.patches.downloads.DownloadsPatch
... 18 more

@oSumAtrIX
Copy link
Member

Are you merging the integrations correctly?

@thijsi123
Copy link

Uhmm, Still no idea what that means, I just select the patches - patch- install as root and then open.

@oSumAtrIX
Copy link
Member

I am unable to reproduce, I'll leave this issue open for someone else to reproduce the same exception.

@thijsi123
Copy link

thijsi123 commented Jan 2, 2023

Seems like that it was the downloader patch, everything works now.

@oSumAtrIX
Copy link
Member

You are using unofficial patches it seems. Reset the sources and it will work again.

@thijsi123
Copy link

Ahh yes, I totally forgot.
Thank you very much!

@ILoveOpenSourceApplications

If everything is solved can this be closed then?

@Ushie Ushie closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants