Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: S Pen interactions crashes manager #390

Closed
4 tasks done
Voiasis opened this issue Oct 12, 2022 · 11 comments
Closed
4 tasks done

bug: S Pen interactions crashes manager #390

Voiasis opened this issue Oct 12, 2022 · 11 comments
Labels
Bug report Something isn't working

Comments

@Voiasis
Copy link

Voiasis commented Oct 12, 2022

Type

Error while running the manager

Bug description

I tried to copy the recommended YouTube version by holding the S Pen button and tapping the screen twice. (It supposed to bring up a s pen tool menu)
The manager crashes immediately on the first tap.
It crashes anywhere within the manager.

Steps to reproduce

  1. Hold S Pen button
  2. Touch screen anywhere in manager

Android version

12

Manager version

0.0.32

Target package name

None

Target package version.

None

Installation type

Non-root

Patches selected.

None

Device logs (exported using Manager settings).

--------- beginning of main
10-11 19:22:44.305  1054  1054 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:23:04.381  1940  1940 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:23:59.583  3587  3587 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:31:24.900  9039  9039 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:32:34.763  9876  9876 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:32:39.162 10022 10022 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:34:48.377 13768 13768 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:35:34.853 13768 13768 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.unregisterNetworkCallback(ConnectivityManager.java:4839)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onCancel(ConnectivityBroadcastReceiver.java:66)] [dev.fluttercommunity.plus.connectivity.ConnectivityPlugin.teardownChannels(ConnectivityPlugin.java:51)] [dev.fluttercommunity.plus.connectivity.ConnectivityPlugin.onDetachedFromEngine(ConnectivityPlugin.java:29)] [io.flutter.embedding.engine.FlutterEngineConnectionRegistry.remove(FlutterEngineConnectionRegistry.java:270)] [io.flutter.embedding.engine.FlutterEngineConnectionRegistry.remove(FlutterEngineConnectionRegistry.java:280)] [io.flutter.embedding.engine.FlutterEngineConnectionRegistry.removeAll(FlutterEngineConnectionRegistry.java:288)] [io.flutter.embedding.engine.FlutterEngineConnectionRegistry.destroy(FlutterEngineConnectionRegistry.java:121)] [io.flutter.embedding.engine.FlutterEngine.destroy(FlutterEngine.java:427)] [io.flutter.embedding.android.FlutterActivityAndFragmentDelegate.onDetach(FlutterActivityAndFragmentDelegate.java:704)] [io.flutter.embedding.android.FlutterActivity.onDestroy(FlutterActivity.java:715)] [android.app.Activity.performDestroy(Activity.java:8571)] [android.app.Instrumentation.callActivityOnDestroy(Instrumentation.java:1364)] [android.app.ActivityThread.performDestroyActivity(ActivityThread.java:6019)] [android.app.ActivityThread.handleDestroyActivity(ActivityThread.java:6077)] [android.app.servertransaction.DestroyActivityItem.execute(DestroyActivityItem.java:47)] [android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:45)] [android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:176)] [android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)] [android.app.ActivityThread$H.handleMessage(ActivityThread.java:2443)]
10-11 19:35:36.540 13768 13768 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]
10-11 19:35:41.187 14577 14577 D ConnectivityManager: StackLog: [android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:4166)] [android.net.ConnectivityManager.registerDefaultNetworkCallbackForUid(ConnectivityManager.java:4730)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4697)] [android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:4671)] [dev.fluttercommunity.plus.connectivity.ConnectivityBroadcastReceiver.onListen(ConnectivityBroadcastReceiver.java:56)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onListen(EventChannel.java:218)] [io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler.onMessage(EventChannel.java:197)] [io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)] [io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)] [io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)]

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

No response

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • The issue is related solely to the ReVanced Manager
@Voiasis Voiasis added the Bug report Something isn't working label Oct 12, 2022
@Aunali321
Copy link
Contributor

Don't have S pen to test. and you can't "copy" over apk. you need to tap the button and select it from your file manager.

@Voiasis
Copy link
Author

Voiasis commented Oct 12, 2022

I can copy any text on the screen with my s pen. It's called "Smart Select". I just double tap the screen, select the area of text I want to copy, select extract text, then copy.
That's what I wanted to do and it crashes.

@Michael1999US
Copy link

Same issue here, touching screen while the button is pressed, crashes Vanced Manager.

@Aunali321
Copy link
Contributor

I can copy any text on the screen with my s pen. It's called "Smart Select". I just double tap the screen, select the area of text I want to copy, select extract text, then copy. That's what I wanted to do and it crashes.

It won't work, because manager isn't copying apk. When you select apk it only it gets it's path. Copying is done afterwards. So no you can't drag and drop apk like that

@Ushie
Copy link
Member

Ushie commented Oct 18, 2022

I can copy any text on the screen with my s pen. It's called "Smart Select". I just double tap the screen, select the area of text I want to copy, select extract text, then copy. That's what I wanted to do and it crashes.

It won't work, because manager isn't copying apk. When you select apk it only it gets it's path. Copying is done afterwards. So no you can't drag and drop apk like that

That's not what they're referring to, they're trying to copy the recommended version text, using a feature called SmartSelect, not the APK

Screenshot_20221018_140730

@Ushie
Copy link
Member

Ushie commented Oct 18, 2022

However I can't test either, as I don't have an S-Pen as well

@Voiasis
Copy link
Author

Voiasis commented Oct 21, 2022

Why can't I be a tester then. I'm a tester for another Android project. Just ping me in the Discord server

@arandomhooman
Copy link

I have a spen. I can test.

@Ushie
Copy link
Member

Ushie commented Nov 3, 2022

I have a spen. I can test.

I don't believe there's a need, I realised recently that this is most likely the same issue as #250

scrape that, that seems to be specific to textfield

@ILoveOpenSourceApplications

Do we have anymore S-Pen users to test this and see if the issue still exists?

@ghost
Copy link

ghost commented Feb 26, 2023

This issue seemed to relate to Flutter issue flutter/flutter#111068
The issue has been fixed in Flutter framework in November 2022, I've done own testing on one of recent versions of ReVanced Manager and can confirm this issue is not present anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants