feat(youtube): Improve patch descriptions

[egscodes]

Application

Youtube

Issue

Some of the patches add a toggle but in the description they don't mention it, they just say it removes stuff

Patch

Description should say "Adds a toggle that ____" (or any variation depending on the context)

This is a list of some of the patches that i use that have a toggle but don't mention them, there's probably more but i don't want to repatch my current apk just to test

• Client spoof (i think)
• Disable auto caption
• Disable shorts on startup
• Disable zoom haptics
• Downloads
• Hdr auto brightness
• Hide album cards
• Hide Artist card
• Hide autoplay button
• Hide breaking news shelf
• Hide create button
• Hide crowdfunding box
• Hide short button
• Hide watch in vr
• hide watermark
• minimized playback
• old quality layout
• open links externally
• seekbar tapping
• spoof app version

Motivation

It will make it easy to know what adds a toggle and what simply just works.

Acknowledgements

• I have searched the existing issues and this is a new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I filled out all of the requested information in this issue properly.

[oSumAtrIX]

The descriptions should be short, can you please suggest short descriptions for every of the toggles you mentioned?

[LisoUseInAIKyrios]

The optional YouTube patches that do not have toggles are:

hide-player-overlay
premium-heading
custom-video-speed
custom-branding
theme

That's 5 patches.

Not counting those 5, there are about 50 other patches that have in app setting switches.

That means nearly every patch would say "adds a toggle for".

[egscodes]

Looking at the descriptions one could either say "Toggle that ----" or it could be written like the Hide player buttons "Adds the option to hide video player previous and next buttons."

Example with disable-auto-captions "Disable forced captions from being automatically enabled."

1. Adds the option to Disable forced captions from being automatically enabled.
2. Adds Toggle that Disables forced captions from being automatically enabled. (one can even remove the word Adds)

[LisoUseInAIKyrios]

If anything, just those 5 patches that are permanent (no way to turn on/off inside the app) should explain they are on all the time.
Not the other way around.

[oSumAtrIX]

@LisoUseInAIKyrios I believe the issue is in the descriptions of the toggle preferences. They just say "enabled" or "disabled" expressing the state of the toggle, whereas the description is meant to describe the toggle, not just express its state.

[LisoUseInAIKyrios]

It would be great if the patches could declare themselves as configurable. And the manager then automatically included and hides the selection of these patches from the user during patching (in other words, they get the patch no matter what)

So the user only needs to decide which of the the permanent patches to include. Which right now is just 5 patches.

Of course, let the user manually include/exclude patches if they wish, but make that an 'expert' mode or something to that effect.

It would dramatically simplify patching, which is intimidating to users when they're asked to pick from 50 patches they don't easily understand.

It would dramatically reduce the number of users who don't follow guides and the users don't use the recommended patches, and then they post the usual "my videos won't play after 30 seconds omg what is this broke app I picked spoof client and it's still broken, what is spoof verification help me omg"

[oSumAtrIX]

Of course, let the user manually include/exclude patches if they wish, but make that an 'expert' mode or something to that effect.

Yes, this is in ongoing discussion in ReVanced Manager repository. The idea is to promote the default selection of patches but allow the user to alter it if they really want to.

[LisoUseInAIKyrios]

@LisoUseInAIKyrios I believe the issue is in the descriptions of the toggle preferences. They just say "enabled" or "disabled" expressing the state of the toggle, whereas the description is meant to describe the toggle, not just express its state.

In that case, maybe just add "allow"

Hide shorts button -> Allow hiding the shorts button

[oSumAtrIX]

The problem is something like "Hide product banner" does not explain what the product banner is. People don't know what they are hiding.

[SodaWithoutSparkles]

Maybe do a screenshot example on what that actually hides

[oSumAtrIX]

There is no room for screenshots in the components and design language that YouTube uses.

[SodaWithoutSparkles]

There is no room for screenshots in the components and design language that YouTube uses.

I mean in some documentation repo

[oSumAtrIX]

All documentation is agnostic to any patch. At max patches can document itself

[KobeW50]

I'd like to PR for this (and #2515)

I think a good wording would be Adds option to... / Adds options to...

I'm not sure if this should be added to every patch that is toggleable . Some patches are essentially necessary and shouldn't be disabled, such as the Client spoof patch. And some have no downside of being enabled (and don't even need a toggle), such as the Video ads and Bypass URL redirects patches.

[oSumAtrIX]

As long as you are consistent in wording and terminology, repetition shouldn't be a problem