Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - Enable slide to seek): Including patch causes issues with clicking and double tapping the video player controls #2439

Open
3 tasks done
SeokHyeonLee opened this issue Dec 15, 2023 · 7 comments · May be fixed by #3629
Labels
Bug report Something isn't working

Comments

@SeokHyeonLee
Copy link

SeokHyeonLee commented Dec 15, 2023

Bug description

revanced-patches : v3.1.0 (also on v2.202.0)
revanced-integrations : v1.0.0
revanced-manager : v1.17.3
revanced-cli : v4.3.0

android version : 9.0(Galaxy Note 8), 11.0 (Galaxy S21U)

The YouTube player is having issues with the pause/play button (player menu buttons) and double-tapping to seek because the clicks are stuck when not zoomed in.
If you zoom 1.1x (but not 1.0x), then the pause/play button and double-tapping to seek will work as normal.

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@SeokHyeonLee SeokHyeonLee added the Bug report Something isn't working label Dec 15, 2023
@oSumAtrIX
Copy link
Member

Disable the slide to seek patch or it's option and check if that make a difference

@oSumAtrIX oSumAtrIX added the Waiting on author Further information is requested label Dec 15, 2023
@SeokHyeonLee
Copy link
Author

Disable the slide to seek patch or it's option and check if that make a difference

already disable slide to seek and swipe controls
all combinations of settings related to interactions are stucked

@oSumAtrIX
Copy link
Member

Follow this and report back:

Screenshot_20231215-085450

@KobeW50
Copy link
Contributor

KobeW50 commented Jan 2, 2024

I believe this has been confirmed by several users that it is indeed the Enable slide to seek patch which causes this, so the "waiting on author" can be removed and perhaps the title can be updated.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug: Clicking issues with the YouTube video player not zoomed in (default) bug(YouTube - including Enable slide to seek): Including patch causes issues with clicking and double tapping the video player controls Jan 2, 2024
@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Jan 2, 2024

To those having the issue, this can be 100% fixed by repatching and excluding Enable slide to seek (turning off the feature in the app settings is not enough).

This also can sometimes be fixed by clearing the app data and launching the app multiple times until the problem is gone.

The problem might be caused by an A/B installation setting that conflicts with the patch.

@LisoUseInAIKyrios LisoUseInAIKyrios removed the Waiting on author Further information is requested label Jan 2, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug(YouTube - including Enable slide to seek): Including patch causes issues with clicking and double tapping the video player controls bug(YouTube - Enable slide to seek): Including patch causes issues with clicking and double tapping the video player controls Jan 2, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug(YouTube - Enable slide to seek): Including patch causes issues with clicking and double tapping the video player controls bug(YouTube - Enable slide to seek): Including patch causes issues with clicking and double tapping the video player controls Jan 2, 2024
@oSumAtrIX
Copy link
Member

The patch should be disabled with a warning or removed at this point in this case.

@LisoUseInAIKyrios
Copy link
Contributor

This issue may be fixed by pull request #3629

The patch description will keep the side effect disclaimer since this bug is very difficult to reproduce, but otherwise it's likely the issue is fixed.

@LisoUseInAIKyrios LisoUseInAIKyrios linked a pull request Sep 29, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants